Skip to content

Fix/vbi component/update component stories#527

Merged
trannhatminhdev merged 2 commits into
mainfrom
fix/vbi-component/update-component-stories
Jul 21, 2026
Merged

Fix/vbi component/update component stories#527
trannhatminhdev merged 2 commits into
mainfrom
fix/vbi-component/update-component-stories

Conversation

@trannhatminhdev

Copy link
Copy Markdown
Collaborator

🤔 This is a ...

  • Bug fix

💡 Background and solution

Background:
Incorrect attribute rendering in Storybook for dropdown and tooltip, and components were not being built before running Storybook.

Solution:

  • Fixed attribute binding logic (using setAttribute) and added the placement option for dropdown/tooltip stories.
  • Added pnpm build to the Storybook build script to ensure the latest component changes are included.

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@trannhatminhdev
trannhatminhdev force-pushed the fix/vbi-component/update-component-stories branch from 870d050 to c9d7b9c Compare July 20, 2026 10:36
@trannhatminhdev
trannhatminhdev merged commit 285072f into main Jul 21, 2026
3 checks passed
@trannhatminhdev
trannhatminhdev deleted the fix/vbi-component/update-component-stories branch July 21, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants