fix: refresh functional icons after theme updates - #5238
Merged
fangsmile merged 1 commit intoJul 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #4816
💡 Background and solution
Built-in functional icons are regenerated when the theme changes, but
HeaderHelper,BodyHelper, andRowSeriesNumberHelperkept the icon objects cached during table initialization. As a result, rebuilding the scenegraph afterupdateOption(),updateTheme(), or assigningthemecontinued to use the previous icon colors.This change adds an
updateIcons()method to the three helpers and refreshes their cached icon definitions immediately after applying functional icon colors.✅ Verification
npm test -- --runInBand __tests__/functional-icons-theme.test.ts __tests__/listTable.test.ts __tests__/options/listTable-icon.test.ts: 15 tests passednpm run compile: passednode common/scripts/install-run-rush.js build -t @visactor/vtable: completed successfully with existing build warningsvtable-sheetdependency/formula tests and thevideo-cell-first-frame.test.tsenvironment tests.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough