fix(vtable): refresh custom merged corner layout - #5288
Merged
Conversation
Recalculate custom merged corner content after resize. Keep it on one render cell to avoid clipping artifacts. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Avoid resize crashes and constrain custom merged corner content to a single clipped container. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep corner merged cells unclipped on default fallback. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Avoid creating custom layout roots for non-carrier cells. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Avoid a second carrier-cell refresh after resize rebuilds the custom layout. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Clear the old React container before rebuilding the merged corner carrier. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep React custom layout teardown synchronous across refresh paths. Avoid deferred cleanup deleting newly mounted containers. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Refresh corner custom merge content after grouped row or column resize updates. Use final dimensions instead of the first intermediate resize state. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep resize refreshes from unmounting corner custom merge React roots. Reuse the existing root while updating the resized container rect. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue link: close #765
Test plan
rushx compilegit pushpre-pushrush test --only tag:package🤖 Generated with Claude Code