Skip to content

Conversation

@maddocnc
Copy link
Collaborator

Adds feature Visual-Regression-Tracker/Visual-Regression-Tracker#237

Adds empty area on smaller image before diff.

Real pixelmatch in getDiff test. fillPng helper for generating test png.

maddocnc and others added 7 commits March 18, 2021 14:06
Adds empty area on smaller image before diff
Adds empty area on smaller image before diff
Adds empty area on smaller image before diff
Adds empty area on smaller image before diff
Adds empty area on smaller image before diff
@pashidlos pashidlos self-requested a review March 20, 2021 20:34
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maddocnc thanks for your contribution!
I've been long time since I wrote this code and reworked it a bit
suggested changes are in PR #116
please, take a look

summary

  • getDiff refactored
  • added feature flag
  • Pixelmatch mock reverted

@pashidlos pashidlos merged commit 109d3b0 into master Mar 22, 2021
@pashidlos pashidlos deleted the diff-any-dimensions branch March 22, 2021 13:54
@pashidlos
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants