Skip to content

Diff any dimensions suggested #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2021
Merged

Diff any dimensions suggested #116

merged 3 commits into from
Mar 22, 2021

Conversation

@pashidlos
Copy link
Member

@pashidlos pashidlos commented Mar 20, 2021 •
edited
Loading

  • getDiff refactored
  • added feature flag
  • Pixelmatch mock reverted

@pashidlos pashidlos requested a review from maddocnc March 20, 2021 20:26
@pashidlos pashidlos mentioned this pull request Mar 20, 2021
Merged
maddocnc
maddocnc approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@maddocnc maddocnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think that tests should test:-) But you are the boss)

@maddocnc maddocnc merged commit 5c0f2e3 into diff-any-dimensions Mar 22, 2021
@pashidlos pashidlos deleted the diff-any-dimensions-suggested branch March 22, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maddocnc maddocnc maddocnc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pashidlos @maddocnc