Skip to content

fix(qc-plots): Fix plot title for all proteins to generalize to metabolites - #216

Merged
tonywu1999 merged 1 commit into
develfrom
fix-plot-title
Aug 1, 2026
Merged

fix(qc-plots): Fix plot title for all proteins to generalize to metabolites#216
tonywu1999 merged 1 commit into
develfrom
fix-plot-title

Conversation

@tonywu1999

@tonywu1999 tonywu1999 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Motivation and context

QC plot titles must support both proteins and metabolites. The change removes protein-specific wording from the all-data QC plot title.

Changes

  • Changed the QC plot title from "All proteins" to "All" in R/utils_dataprocess_plots.R.
  • No exported or public entities changed.

Unit tests

  • No unit tests were added or modified.

Coding guidelines

  • No coding guideline violations were identified.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The all-proteins QC plot title changes from "All proteins" to "All".

Changes

QC Plot Title

Layer / File(s) Summary
Update all-proteins QC title
R/utils_dataprocess_plots.R
The all-proteins QC plot now uses the title "All".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny trims the title line,
“All” now fits the plot just fine.
One small change, neat and bright,
QC labels look concise tonight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the change to generalize the QC plot title for proteins and metabolites.
Description check ✅ Passed The description explains the motivation and changes, and it states that no tests were added; the checklist is missing.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-plot-title

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tonywu1999 tonywu1999 changed the title fix(qc-plots): Fix plot title for all proteins to generalize to metab… fix(qc-plots): Fix plot title for all proteins to generalize to metabolites Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Failed to generate code suggestions for PR

@tonywu1999
tonywu1999 merged commit f5259ee into devel Aug 1, 2026
4 checks passed
@tonywu1999
tonywu1999 deleted the fix-plot-title branch August 1, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant