add-targetsdk-28-upgrade #171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @teeolendo! If anyone has time to test this and report back that would be a big help getting this merged |
|
Tested, works fine for me |
Contributor
|
@teeolendo can you rebase please? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
# [5.4.0](v5.3.0...v5.4.0) (2020-03-27) ### Features * [Android] bump minSDK to 18, targetVersion to 28. Closes [#171](#171) ([a7968f9](a7968f9))
|
🎉 This issue has been resolved in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Google. From November 1, 2019, all updates must target at least Android 9.0 / API level 28. Furthermore, all new uploads have to comply with this requirement. If you're build a new app, this is the basic requirement. When using RN 0.60+ you have to upgrade the minsdk or else the app will either not build or the background upload will crash while trying to update. Issue #169 details this issue further.
Repro: https://github.com/teeolendo/ReactNativeBackgroundUploadExample