Skip to content

add-targetsdk-28-upgrade #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add-targetsdk-28-upgrade #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
## Issues
## Issues

Along with a bug report, provide a functional example repository which
reproduces the bug you're experiencing. We've made this very easy by providing
a full-stack (React Native + Express.js) example app, which you can fork and
alter to reproduce your bug:
According to Google. From November 1, 2019, all updates must target at least Android 9.0 / API level 28. Furthermore, all new uploads have to comply with this requirement. If you're build a new app, this is the basic requirement. When using RN 0.60+ you have to upgrade the minsdk or else the app will either not build or the background upload will crash while trying to update. Issue #169 details this issue further.

[ReactNativeBackgroundUploadExample](https://github.com/Vydia/ReactNativeBackgroundUploadExample)
[Repro](https://github.com/teeolendo/ReactNativeBackgroundUploadExample)
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ android {
buildToolsVersion project.hasProperty('buildToolsVersion') ? project.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION

defaultConfig {
minSdkVersion 16
minSdkVersion 18
targetSdkVersion project.hasProperty('targetSdkVersion') ? project.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION
versionCode 1
versionName "1.0"
Expand All @@ -36,5 +36,5 @@ repositories {
}
dependencies {
compile 'com.facebook.react:react-native:+'
compile 'net.gotev:uploadservice-okhttp:3.4.2'
compile 'net.gotev:uploadservice-okhttp:3.5.0'
}