Merged
Conversation
Contributor
Author
|
@rowandempster ready to be reviewed and merged |
Contributor
rowandempster
left a comment
rowandempster
left a comment
There was a problem hiding this comment.
Code looks good! A few usability / refactoring comments
Contributor
|
Also, can you confirm that you tested:
|
Contributor
Author
Tested in VScode and terminal, both work |
rowandempster
approved these changes
Feb 8, 2023
Contributor
rowandempster
left a comment
rowandempster
left a comment
There was a problem hiding this comment.
LGTM, you'll have to rebase since my merge of the visual data helper stuff yesterday, lemme know if you need help resolving those conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes permission inside the docker container as per https://github.com/boxboat/fixuid
Note: this only fixes uid issues with pgp. If you want your container fixed, please contact @Edwardius