fix(ci): replace unavailable gcc-13/g++-13 with gcc/g++ in CodeQL workflow - #207
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
.github/workflows/codeql.yml:50
- The build step hard-codes
gcc/g++. If the workflow installs a newer compiler (needed for the project’s C++23std::generatorusage), this step should also point CMake at the same toolchain to avoid accidentally building with the older default compiler.
env:
CC: gcc
CXX: g++
run: |
cmake -B _build -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++
cmake --build _build --parallel $(nproc)
clauspruefer
left a comment
There was a problem hiding this comment.
@copilot this will not fix the problem! We need a gcc >= 13 and g++ >= 13 which is not the case anymore with changing back to gcc and g++ from gcc-13 and g++-13 or did you update the base Ubuntu VM image used to a newer one? If not, check how to install the gcc-14 and g++14 packages.
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Updated in commit 62e128b: the CodeQL workflow now adds |
gcc-13/g++-13are no longer locatable as packages on theubuntu-22.04GitHub Actions runner image, causing the "Analyze (c-cpp)" CodeQL job to fail at the dependency install step.Changes
.github/workflows/codeql.ymlgcc-13 g++-13withgcc g++inapt-get installCC/CXXenv vars and-DCMAKE_C_COMPILER/-DCMAKE_CXX_COMPILERflags accordingly