Skip to content

ci: fix CodeQL C/C++ build by switching to ubuntu-24.04 - #209

Merged
clauspruefer merged 1 commit into
mainfrom
copilot/fix-analyze-c-cpp-job-failure
Aug 7, 2026
Merged

ci: fix CodeQL C/C++ build by switching to ubuntu-24.04#209
clauspruefer merged 1 commit into
mainfrom
copilot/fix-analyze-c-cpp-job-failure

Conversation

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The CodeQL "Analyze (c-cpp)" job was failing due to an incompatibility between nlohmann-json 3.10.x (shipped by ubuntu-22.04) and gcc-14 from the toolchain PPA — specifically, the newer libstdc++ made implicit conversion from nlohmann::basic_json<>::value_type to std::vector<std::string> ambiguous at assignment sites like:

Mimetypes = jsonData["server"]["mimetypes"];  // ambiguous operator= with nlohmann 3.10.x + gcc-14

Changes

  • .github/workflows/codeql.yml
    • Switch runner from ubuntu-22.04ubuntu-24.04, which ships gcc-14/g++-14 natively and nlohmann-json 3.11.x (resolves the ambiguous conversion)
    • Remove software-properties-common, add-apt-repository, and the ubuntu-toolchain-r/test PPA steps — no longer needed

Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Copilot AI changed the title ci: fix Analyze (c-cpp) by switching to ubuntu-24.04 ci: fix CodeQL C/C++ build by switching to ubuntu-24.04 Aug 7, 2026
Copilot AI requested a review from clauspruefer August 7, 2026 06:58
@clauspruefer
clauspruefer marked this pull request as ready for review August 7, 2026 06:58
Copilot AI lite review requested due to automatic review settings August 7, 2026 06:58
@clauspruefer
clauspruefer merged commit a14915c into main Aug 7, 2026
5 of 7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the CodeQL workflow runner to Ubuntu 24.04 to resolve a C/C++ CodeQL build failure caused by the Ubuntu 22.04 + gcc-14 toolchain PPA combination (notably around nlohmann-json 3.10.x with newer libstdc++).

Changes:

  • Switch CodeQL “Analyze (c-cpp)” job runner from ubuntu-22.04 to ubuntu-24.04.
  • Remove the toolchain PPA bootstrap steps (software-properties-common, add-apt-repository, ppa:ubuntu-toolchain-r/test) since they’re no longer needed on 24.04.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants