Disable SIGPIPE signal - #19
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change is small and directly addresses the SIGPIPE-induced test failures, with only minor robustness/style improvements suggested in comments.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR prevents the Linux server test harness from being terminated by SIGPIPE when a client closes the connection mid-response, so write failures surface as normal I/O errors instead of killing the process.
Changes:
- Add signal handling setup in
linux_server/main.cppto ignoreSIGPIPE.
File summaries
| File | Description |
|---|---|
| linux_server/main.cpp | Ignores SIGPIPE at process startup to stop abrupt termination on broken pipe during socket writes. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| #include <string> | ||
| #include <thread> | ||
|
|
||
| #include <signal.h> |
Comment on lines
+49
to
+50
| //- ignore PIPE signal | ||
| signal(SIGPIPE, SIG_IGN); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linux server tests failed because when the connection on receiver side was closed unexcpectedly, linux sends a SIGPIPE, so the server was closed silently. Disabling SIGPIPE prevents this, now tests work fine.