Fixing inconsistent sign in the RM3 example#58
Closed
jleonqu wants to merge 3 commits intoWEC-Sim:devfrom
Closed
Conversation
Contributor
|
This fix works. I do request that the run time is set back to ~400 seconds so that the test cases do not need to run to 2000 s, but the long run is was a good test case (I do not have write access to this fork). Ready to merge. |
H0R5E
force-pushed
the
dev
branch
3 times, most recently
from
7760345 to
2125949
Compare
Contributor
|
@jleonqu Based on the error message in the runner, it seems there's still an issue with the fix in the PTO-Sim library. Warning message: The case ends up failing because the simulation goes unstable. |
Contributor
Author
Contributor
|
I successfully ran this example in windows 2023b... not sure why the test is not passing but can confirm that this works (using the library change in WEC-Sim PR in #1236 It seems that when #1236 is merged (and pushed to Dev) these tests should pass. Running this sim on dev branch will cause the displayed error. |
Contributor
Author
|
Closing this PR. The PR #60 was created to rebase this PR to the main branch. |
kmruehl
added a commit
that referenced
this pull request
Sep 16, 2024
* Rebase PR #58 to main - Fixing inconsistent sign in the RM3 example (#60) * Fixing the inconsistent sign in the RM3 example * Fix sign bug on OSWEC Hydraulic PTO examples * Update wecSimInputFile.m * Add files via upload Fixes a bug, the main .xls file is replaced with the main .xls file for this example * Fixes bugs with PTO-Sim * fix in wecSimInputFile for morisonElement * Control Test Folder Selection with Dynamic Workflows (#63) * Test dispatch workflow with automatic folder discovery * Set MATLAB version to 2023b * I forgot the R * Check out the correct branch for test discovery * Try it without toJSON * Update workflow for other events Also remove dev workflow as it should work on any branch now. * Need fetch depth for git diff * Set branch correctly and don't run of no folder * Be more explicit with the empty condition * Try and examine what is in the folder variable * Try checking againt empty JSON array string * Test diffed folder * Try diffing two folders and echoing reusable workflow inputs * Try reordering the matrix * Try using a fixed os * Try to prevent included cases running when no folder * Curb my ambition! * Exclude matching cases rather than include * Remove the include conditions * Record required MATLAB packages in each test directory * Export products into test matrix * Dynamically create include cases * Debug input names * Examine the include input variables * Fix length one include array * Consider the base ref for pull requests * Explicitly set the checkout repo * Include repository in the reusable test inputs * Use full repo name * Set runs-on from matrix * Update README * Update badges * Link to process-events workflow * Try adding concurrency term to stop runs for each PR commit * Switch to shields.io badges to customize the labels Also prettify the file. * Split process events workflow to allow sensible badges Badges set to a particular branch don't capture the status of repository dispatch events. * Refactor test workflows Test workflows are refactored to split out those triggered by WEC-Sim commits (wec-sim-***-tests) from those triggered by modifications to the applications (changed-tests). --------- Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com> Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> Co-authored-by: Shabara <mshabara@nrel.gov> Co-authored-by: Forbush <dforbus@sandia.gov> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to the RM3 example based on this PR in the WEC-Sim repo: PR #1221
Which was based on this Issue from the WEC-Sim repo: Issue #1218