Conversation
I think the intent here matches WebIDL's "nullable" concept, which also happens to line up with Chromium's current behavior (which returns `null` rather than `undefined` if a position hasn't yet been obtained).
position and positionError nullable.position and error nullable.
otherdaniel
reviewed
Nov 18, 2025
permission-elements.bs
Outdated
| greater than zero. | ||
| 1. Initialize the internal {{[[position]]}} to undefined. | ||
| 1. Initialize the internal {{[[positionError]]}} to undefined. | ||
| 1. Initialize the internal {{[[position]]}} to `null`. |
Collaborator
There was a problem hiding this comment.
editorial nitpick: Infra spec wants null to be regular text, not null.
(I found that surprising as well, but... it does match common use in other specs.)
Member
Author
There was a problem hiding this comment.
Meh. Infra seems wrong, but I changed the PR anyway. :)
otherdaniel
approved these changes
Nov 18, 2025
Member
Author
|
(I landed this; if you still wish to see changes, lmk.) |
github-actions bot
added a commit
to otherdaniel/PEPC
that referenced
this pull request
Nov 25, 2025
github-actions bot
added a commit
to otherdaniel/PEPC
that referenced
this pull request
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the intent here matches WebIDL's "nullable" concept, which also happens to line up with Chromium's current behavior (which returns
nullrather thanundefinedif a position hasn't yet been obtained).