Fix resource leak

[WSQS]

Summary by CodeRabbit

• Bug Fixes
  • Ensures GPU window binding is explicitly released after graphics pipeline release during the main loop.
  • Ensures GPU window binding is explicitly released after graphics pipeline release during application quit, improving GPU resource cleanup and lifecycle management.

[coderabbitai]

Walkthrough

Adds explicit GPU window binding release calls in two cleanup locations within main.cpp—after graphics pipeline release in both the main loop and quit function. These changes establish proper resource cleanup sequencing for GPU window bindings.

Changes

Cohort / File(s)	Summary
GPU Window Binding Cleanup main.cpp	Added SDL_ReleaseWindowFromGPUDevice calls after graphics pipeline release in the main loop and quit function to ensure proper cleanup order for GPU window resources

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Highly repetitive changes (identical pattern applied in two locations)
• Single file with straightforward additions
• No complex logic modifications
• Resource cleanup sequencing only

Poem

🐰 Window bindings released with grace,
After pipelines clear the space,
Cleanup order, now pristine and right,
GPU resources say goodnight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix resource leak' directly relates to the main change—adding explicit GPU window binding release to prevent resource leaks.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_resource_leak

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aede3a0 and fcd4ca0.

📒 Files selected for processing (1)

• main.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: build (Release, gcc)
• GitHub Check: build (Release, clang)
• GitHub Check: build (Debug, clang)
• GitHub Check: build (Debug, gcc)
• GitHub Check: build (windows-latest, Debug, cl)
• GitHub Check: build (windows-latest, Release, cl)
• GitHub Check: build (windows-latest, Release, gcc)
• GitHub Check: build (windows-latest, Release, clang)
• GitHub Check: build (windows-latest, Debug, gcc)
• GitHub Check: build (windows-latest, Debug, clang)
• GitHub Check: build (windows-latest, Release, clang)
• GitHub Check: build (Release, clang)
• GitHub Check: build (windows-latest, Debug, gcc)
• GitHub Check: build (windows-latest, Debug, clang)
• GitHub Check: build (windows-latest, Release, gcc)
• GitHub Check: build (Release, gcc)
• GitHub Check: build (Debug, gcc)
• GitHub Check: build (windows-latest, Release, cl)
• GitHub Check: build (Debug, clang)
• GitHub Check: build (windows-latest, Debug, cl)

🔇 Additional comments (1)

main.cpp (1)

276-277: Verify: AI summary mentions changes in the main loop that aren't visible.

The AI summary states that SDL_ReleaseWindowFromGPUDevice was added "in the main loop, after SDL_ReleaseGPUGraphicsPipeline" (line 276), but I don't see this change in the annotated code. Only the quit function shows the addition of SDL_ReleaseWindowFromGPUDevice.

If the change was intended for the main loop as well, it appears to be missing. However, releasing and reclaiming the window during pipeline recreation is likely unnecessary—window claiming is typically a one-time setup operation.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[deepsource-io]

Here's the code health analysis summary for commits b6a0af4..fcd4ca0. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
C & C++	❌ Failure	❗ 1 occurence introduced	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6a0af4 and aede3a0.

📒 Files selected for processing (1)

• main.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: build (windows-latest, Release, cl)
• GitHub Check: build (windows-latest, Release, gcc)
• GitHub Check: build (windows-latest, Debug, cl)
• GitHub Check: build (windows-latest, Debug, gcc)
• GitHub Check: build (windows-latest, Debug, clang)
• GitHub Check: build (Release, gcc)
• GitHub Check: build (windows-latest, Release, clang)
• GitHub Check: build (Release, clang)
• GitHub Check: build (Debug, clang)
• GitHub Check: build (Debug, gcc)
• GitHub Check: build (Debug, gcc)
• GitHub Check: build (Release, gcc)
• GitHub Check: build (Release, clang)
• GitHub Check: build (Debug, clang)
• GitHub Check: build (windows-latest, Release, cl)
• GitHub Check: build (windows-latest, Release, clang)
• GitHub Check: build (windows-latest, Debug, gcc)
• GitHub Check: build (windows-latest, Debug, cl)
• GitHub Check: build (windows-latest, Debug, clang)
• GitHub Check: build (windows-latest, Release, gcc)

🔇 Additional comments (1)

main.cpp (1)

364-364: AI summary inconsistency: Only one reset call added, not two.

The AI summary states that gpu_wrapper.reset() is added at two cleanup points (in the main loop and in quit), but only one addition is visible in the code at line 364 in the quit() function. There is no marked addition in the iterate() function (the main loop).