-
Notifications
You must be signed in to change notification settings - Fork 0
Add workflow Gen pr #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a manually-triggered GitHub Actions workflow to generate PRs from issues and a configuration file for the PR-generation AI, specifying models, tooling, extra args, verbosity, and a test command. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User as Developer (manual trigger)
participant GH as GitHub Actions
participant Repo as Repository (checkout)
participant Action as gen-pr Action
participant AI as OpenRouter / Model API
Note over GH,Action: Environment: GITHUB_TOKEN, OPENROUTER_API_KEY
User->>GH: Manually trigger "Generate PR with AI"
GH->>Repo: checkout repository
GH->>Action: invoke WillBooster/gen-pr with config
Action->>AI: send planning-model & extra args (polaris-alpha, repomix args, aider args)
AI-->>Action: return plan / patch
Action->>GH: create PR (uses GITHUB_TOKEN)
GH-->>User: PR created / notification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Here's the code health analysis summary for commits Analysis Summary
|
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.github/workflows/gen-pr.yml (1)
28-33: Model specification is duplicated between workflow and configuration.Line 32 passes
--model openrouter/openrouter/polaris-alphato aider-extra-args, whilegen-pr.config.yml(line 8) also specifies the same model. This duplication could lead to inconsistency if one is updated without the other. Consider relying solely on the config file and removing the redundant argument here, or document why both are needed.Consider this simplified approach:
- name: Generate PR from issue using OpenRouter uses: WillBooster/gen-pr@v4.1.4 with: issue-number: ${{ inputs.issue-number }} - aider-extra-args: "--model openrouter/openrouter/polaris-alpha" verbose: truegen-pr.config.yml (2)
2-2: Align model specification strategy across workflow and config.The planning-model (line 2) and aider-extra-args (line 8) both specify
openrouter/openrouter/polaris-alpha, which duplicates the model passed via workflow argument (.github/workflows/gen-pr.ymlline 32). Establish a single source of truth: either rely entirely on configuration here or remove it from the config and pass it only via the workflow.Also applies to: 8-8
11-12: Consider the applicability and generality of project-specific settings.The test-command
cmake -S . -B buildis specific to C++ projects using CMake. If this config is shared across repositories or used in environments where CMake is not available, this could cause failures. Either document when this config applies, parameterize the test command, or ensure all repos using this workflow are C++ CMake-based projects.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/gen-pr.yml(1 hunks)gen-pr.config.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: build (windows-latest, Release, cl)
- GitHub Check: build (windows-latest, Release, clang)
- GitHub Check: build (windows-latest, Debug, cl)
- GitHub Check: build (windows-latest, Debug, gcc)
- GitHub Check: build (windows-latest, Release, gcc)
- GitHub Check: build (windows-latest, Debug, clang)
- GitHub Check: clang-tidy-review
- GitHub Check: build (Release, clang)
- GitHub Check: build (Debug, clang)
- GitHub Check: build (Release, gcc)
- GitHub Check: build (Debug, gcc)
🔇 Additional comments (1)
.github/workflows/gen-pr.yml (1)
1-33: Verify the OPENROUTER_API_KEY secret is configured and documented.The workflow requires
secrets.OPENROUTER_API_KEYto be defined in repository settings, but there's no documentation or validation that it exists. Consider adding a comment or documentation on how to set up this secret.
|
clang-tidy review says "All clean, LGTM! 👍" |
* feat: add class PileLineWrapper * feat: add pipe line wrapper to User App * refactor: rename class * feat:code rabbit enable auto_apply_labels * fix: add check before release pipeline Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix:handle SDL_CreateGPUGraphicsPipeline error * fix:call sdl init before app init * feat: add class gpu wrapper * style: format code with ClangFormat This commit fixes the style issues introduced in 46e77a7 according to the output from ClangFormat. Details: #7 * 📝 Add docstrings to `pipiline` (#8) * 📝 Add docstrings to `pipiline` Docstrings generation was requested by @WSQS. * #7 (comment) The following files were modified: * `main.cpp` * `sdl_wrapper/sdl_callback_implement.cpp` * style: format code with ClangFormat This commit fixes the style issues introduced in 49e577b according to the output from ClangFormat. Details: #8 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * fix:change log * fix:cadd check for gpu wrapper * fix:using gpu wrapper in buffer wrapper * fix:rename variable * fix:change vertex buffer to value semantics * style: format code with ClangFormat This commit fixes the style issues introduced in 9cd5876 according to the output from ClangFormat. Details: #7 * fix: remote typo * break: split implement unit of module * style: format code with ClangFormat This commit fixes the style issues introduced in 9796426 according to the output from ClangFormat. Details: #7 * fix: add log for windows ci * fix: rename log name * fix: Add type * style: format code with ClangFormat This commit fixes the style issues introduced in f75fa22 according to the output from ClangFormat. Details: #7 * fix: Add module unit sdl_wrapper:decl * Fix resource leak (#10) * feat:release gpu before windows * feat:release window from gpu devices --------- Co-authored-by: Sophomore <sophomore@duck.com> * fix: remove todo, the destroy order is defined by shared_ptr * feat: add function create_buffer to GpuWrapper * style: format code with ClangFormat This commit fixes the style issues introduced in 60d5ebd according to the output from ClangFormat. Details: #7 * 📝 Add docstrings to `pipiline` (#9) * 📝 Add docstrings to `pipiline` Docstrings generation was requested by @WSQS. * #7 (comment) The following files were modified: * `main.cpp` * `sdl_wrapper/sdl_callback_implement.cpp` * `sdl_wrapper/sdl_wrapper.buffer.cpp` * style: format code with ClangFormat This commit fixes the style issues introduced in 32e7ade according to the output from ClangFormat. Details: #9 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: WSQS <17792626+WSQS@users.noreply.github.com> * Add workflow clang-tidy-review * fix:workflow set compiler * fix:install package for ubuntu * fix:add parameter * fix:add parameter * fix:add permission * fix:remove bom * fix:change command * Add workflow Gen pr (#16) * Add workflow * feat: Add permission * feat: change model * feat: add include file * feat: change key word * feat: set workflow in aider * feat: enable verbose * feat: enable verbose * feat: enable verbose * feat: remove bom --------- Co-authored-by: Sophomore <sophomore@duck.com> * feat: let gpu create pipeline * style: format code with ClangFormat This commit fixes the style issues introduced in db03e22 according to the output from ClangFormat. Details: #7 * Remove unused headfile Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * style: format code with ClangFormat This commit fixes the style issues introduced in 721f0ef according to the output from ClangFormat. Details: #7 * fix: change comment * fix: add header file * style: format code with ClangFormat This commit fixes the style issues introduced in d9851ce according to the output from ClangFormat. Details: #7 * fix: remove unused file. * 📝 Add docstrings to `pipiline` (#17) * 📝 Add docstrings to `pipiline` Docstrings generation was requested by @WSQS. * #7 (comment) The following files were modified: * `main.cpp` * `sdl_wrapper/sdl_wrapper.buffer.cpp` * `sdl_wrapper/sdl_wrapper.pipeline.cpp` * style: format code with ClangFormat This commit fixes the style issues introduced in c7383b5 according to the output from ClangFormat. Details: #17 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * fix: from optional to value * feat: add compile command * feat:implement pipeline_wrapper * style: format code with ClangFormat This commit fixes the style issues introduced in b70c22e according to the output from ClangFormat. Details: #7 * fix: shader length error * fix: rename variable * fix: rename function * fix: change shader code * fix: avoid resource leak * fix: change primitive type * 📝 Add docstrings to `pipiline` (#19) * 📝 Add docstrings to `pipiline` Docstrings generation was requested by @WSQS. * #7 (comment) The following files were modified: * `main.cpp` * `sdl_wrapper/sdl_wrapper.buffer.cpp` * `sdl_wrapper/sdl_wrapper.pipeline.cpp` * style: format code with ClangFormat This commit fixes the style issues introduced in 66165a8 according to the output from ClangFormat. Details: #19 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> --------- Co-authored-by: Sophomore <sophomore@duck.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit