Skip to content

Dtype parameterization#106

Merged
vdplasthijs merged 9 commits into
developfrom
feature/dtypes
May 21, 2026
Merged

Dtype parameterization#106
vdplasthijs merged 9 commits into
developfrom
feature/dtypes

Conversation

@gabrieletijunaityte

@gabrieletijunaityte gabrieletijunaityte commented May 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Added dtype parameter per modality, supported through hydra configs.
  • Added dtype parameter for prediction head and normalisation layer, to unify model weight dtypes.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?

@gabrieletijunaityte gabrieletijunaityte marked this pull request as draft May 13, 2026 07:53
@gabrieletijunaityte gabrieletijunaityte marked this pull request as ready for review May 13, 2026 08:03
Comment thread src/data/base_dataset.py Outdated
@gabrieletijunaityte gabrieletijunaityte mentioned this pull request May 20, 2026
4 tasks

@vdplasthijs vdplasthijs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we parameterise how Tessera Nans are handled via an arg in base dataset?

Comment thread src/data/base_dataset.py Outdated
Comment thread src/data/base_dataset.py
@gabrieletijunaityte

Copy link
Copy Markdown
Contributor Author

@vdplasthijs @robknapen it's ready for a second round of checking 😅

Comment thread src/data/base_dataset.py
@vdplasthijs vdplasthijs merged commit 4e472ac into develop May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants