Feature/spatial splits#61
Merged
Merged
Conversation
vdplasthijs
reviewed
Mar 11, 2026
vdplasthijs
reviewed
Mar 11, 2026
vdplasthijs
approved these changes
Mar 11, 2026
vdplasthijs
left a comment
vdplasthijs
left a comment
Collaborator
There was a problem hiding this comment.
All looks good, great thank you! Cool implementation of DBScan!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spatial-cluster split strategy for crop yield experiments
A random 70/15/15 split for yield_africa allows nearby fields, and the same field across different years, to appear in both train and test. Because agricultural yield is strongly spatially autocorrelated (shared soils, rainfall patterns, agro-ecological zones), this inflates apparent generalisation performance. The spatial-cluster split closes this loophole by ensuring that no two geographically close locations straddle a split boundary.