-
-
Notifications
You must be signed in to change notification settings - Fork 382
refactor(codex): run host-installed codex CLI instead of bundled SDK #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+655
−269
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Do not require a host Codex installation in this unit test.
This assertion probes the real host environment. It fails on clean developer or CI hosts without a compatible Codex CLI. Use a controlled
CODEX_COMMANDfixture that emits a supported version. If this is an integration check, separate it and skip it when the host requirement is absent.🧰 Tools
🪛 GitHub Actions: CI / 0_Smoke (macos-latest).txt
[error] 12-12: npm test failed: AssertionError expected true but received false (false !== true).
🪛 GitHub Actions: CI / 1_Smoke (ubuntu-latest).txt
[error] 12-12: npm test failed: AssertionError [ERR_ASSERTION] expected true but received false.
🪛 GitHub Actions: CI / 2_Smoke (windows-latest).txt
[error] 12-12: Test assertion failed: expected true but received false (AssertionError [ERR_ASSERTION]). The npm test command failed with exit code 1.
🪛 GitHub Actions: CI / Smoke (macos-latest)
[error] 12-12: npm test failed: assertion expected true but received false (AssertionError [ERR_ASSERTION]). Command failed with exit code 1.
🪛 GitHub Actions: CI / Smoke (ubuntu-latest)
[error] 12-12: Test assertion failed: expected true but received false (AssertionError [ERR_ASSERTION]). The 'npm test' command failed with exit code 1.
🪛 GitHub Actions: CI / Smoke (windows-latest)
[error] 12-12: npm test failed: AssertionError because the actual value was false but the expected value was true. Command failed with exit code 1.
🤖 Prompt for AI Agents