test: align coverage with public seams - #275
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis PR realigns tests around externally observable behavior and makes the provider availability checker module-private.
Confidence Score: 5/5The PR appears safe to merge, with no concrete behavioral, build, or security regression identified. The only production change narrows an unused internal export, while the test changes retain coverage at the public seams and do not alter runtime behavior.
|
| Filename | Overview |
|---|---|
| src/local-agent-availability.ts | Makes the single-provider availability checker private while retaining the snapshot API used by production callers. |
| src/local-agent-availability.test.ts | Replaces environment-dependent helper tests with a deterministic assertion through the snapshot API. |
| src/local-agent-acp.test.ts | Removes runtime-key implementation assertions while retaining ACP command and sandbox mapping coverage. |
| src/local-agent-codex.test.ts | Removes resolver-cache and runtime-key representation assertions while preserving Codex behavior tests. |
| src/local-agent-presentation.test.ts | Keeps structured presentation coverage while dropping exact formatter-string assertions. |
| src/ui/card-types.test.ts | Tests shared expandability behavior directly; initial expansion currently delegates to that same behavior. |
Reviews (1): Last reviewed commit: "test: keep agent formatting at CLI seam" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #265. A few tests still exercised internal helper structure, live environment state, or exact internal representations rather than behavior at the seam callers actually use. Those checks made refactors noisier without protecting meaningful DevSpace behavior.
This keeps coverage at public or external boundaries: provider availability is verified through the production snapshot API, CLI-facing structured presentation remains covered without freezing formatter helpers, and security-sensitive provider command/sandbox mappings stay intact.