Fix AGENTS realpath containment on CI#66
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesAlias Root Realpath Resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant workspaces.test.ts
participant loadInitialAgentsFiles
participant tryRealpath
participant readResolvedContextFile
workspaces.test.ts->>loadInitialAgentsFiles: open workspace at aliasRoot
loadInitialAgentsFiles->>tryRealpath: resolve root
tryRealpath-->>loadInitialAgentsFiles: resolvedRoot
loadInitialAgentsFiles->>tryRealpath: resolve agentDir
tryRealpath-->>loadInitialAgentsFiles: resolvedAgentDir
loadInitialAgentsFiles->>readResolvedContextFile: read with resolvedRoot and resolvedAgentDir
readResolvedContextFile-->>loadInitialAgentsFiles: content
loadInitialAgentsFiles-->>workspaces.test.ts: agentsFiles
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Context
PR #65 passed on Ubuntu but failed macOS and Windows smoke tests because resolved file paths were compared against non-canonical roots, causing initial AGENTS files to be skipped.
Tests
Summary by CodeRabbit