fix(infra): switch testnet DBs to x86#314
Conversation
|
Claude finished @xDarksome's task in 1m 38s —— View job Code ReviewIssue 1: Commit Message Contradicts Code Change The commit message "switch operator-b db to arm" contradicts the actual code change, which switches operator-b to x86 architecture. The change adds Based on infra/modules/service/main.tf:59, when
The commit message should accurately describe switching FROM arm TO x86, not the reverse. Issue 2: Inconsistent Pattern With Other Operators After this change, testnet will have:
The wallet-connect operator includes a comment explaining why it uses x86 ("so we have both architectures being actively tested"). However, operator-b's switch to x86 lacks similar documentation. Given the PR description mentions ARM instability during data migrations, this critical context should be documented inline for future maintainers. Issue 3: Incomplete Migration Strategy If ARM has fundamental instability issues with RocksDB during migrations (not just testing diversity), only switching 1 of 4 operators to x86 leaves 3 operators (operator-a, operator-c, operator-d) vulnerable to the same crashes. The PR description suggests this is a reliability fix, not a testing strategy. Consider whether all testnet DB instances should migrate to x86, or clarify if this is a gradual rollout strategy. |
There was a problem hiding this comment.
Pull request overview
This PR addresses RocksDB stability issues on ARM architecture by switching all testnet database instances to x86. Previously, only the wallet-connect operator used x86 for testing purposes, while other operators defaulted to ARM.
Changes:
- Sets default database architecture to x86 for all testnet operators
- Removes the special-case x86 override for the wallet-connect operator
- Minor formatting cleanup in IAM policy alignment
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/testnet/main.tf | Adds cpu_arch = "x86" to the shared db_config, ensuring all testnet database instances use x86 architecture; removes now-redundant override for wallet-connect operator |
| infra/modules/service/main.tf | Aligns formatting of Effect and Action fields in S3 IAM policy statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
ARM instances are totally unstable during data migrations. There's some issue in RocksDB on ARM making it periodically crash.
How Has This Been Tested?
Manually
Due Diligence