Skip to content

feat(terraform): remove 3 WalletConnect node operators from EU - #336

Merged
xDarksome merged 1 commit into
mainfrom
feat/remove-3-wc-operators-from-eu
Jul 28, 2026
Merged

feat(terraform): remove 3 WalletConnect node operators from EU#336
xDarksome merged 1 commit into
mainfrom
feat/remove-3-wc-operators-from-eu

Conversation

@xDarksome

@xDarksome xDarksome commented Jul 28, 2026

Copy link
Copy Markdown
Member

Description

These deployments have been removed from the keyspace already.

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown

Claude finished @xDarksome's task in 1m 11s —— View job


Todo List

  • Analyze PR changes
  • Review Terraform configuration changes
  • Check for orphaned files
  • Scan for external URLs
  • Report findings

Review Findings

Issue 1: Orphaned SOPS Configuration Files

The PR removes 3 operator configurations from Terraform but their SOPS secret files remain:

Files to remove:

  • infra/mainnet/sops/eu.wallet-connect-3.json
  • infra/mainnet/sops/eu.wallet-connect-4.json
  • infra/mainnet/sops/eu.wallet-connect-5.json

Rationale: These files are referenced via sops_file_path = "${path.module}/sops/eu.${each.key}.json" in the module configuration (line 260). Since wallet-connect-3, wallet-connect-4, and wallet-connect-5 are removed from local.eu_operators, these SOPS files are no longer used and should be deleted to maintain consistency and avoid confusion.


Issue 2: VPC CIDR Overlap Documentation

All 3 removed operators used vpc_cidr_octet = 0 (10.0.0.0/16), which is the same CIDR block. This configuration would cause VPC CIDR conflicts if deployed simultaneously. While the PR description states these were already removed from the keyspace (suggesting they may never have been fully deployed), this raises questions about the configuration's validity.

Recommendation: If these were test/placeholder configurations that were never deployed, consider adding a comment in the PR description to clarify this context for future reference.


@xDarksome
xDarksome requested a review from mario-reown July 28, 2026 10:11
@xDarksome
xDarksome merged commit e998e2b into main Jul 28, 2026
13 checks passed
@xDarksome
xDarksome deleted the feat/remove-3-wc-operators-from-eu branch July 28, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants