Skip to content

fix(sync): make transfers atomic and validate mappings - #5

Merged
nibra180 merged 1 commit into
mainfrom
fix/critical-sync-audit
Jul 29, 2026
Merged

fix(sync): make transfers atomic and validate mappings#5
nibra180 merged 1 commit into
mainfrom
fix/critical-sync-audit

Conversation

@nibra180

Copy link
Copy Markdown
Contributor

Summary

  • Make FTP and SFTP uploads and downloads atomic through staged temporary files.
  • Preserve existing targets and file modes when transfers fail or complete.
  • Validate mapping paths, traversal, duplicates, and ambiguous overlaps during load, save, and runtime translation.
  • Add mapping, writer, pathmap, SFTP, FTP, and host-form test coverage.
  • Document the sync-core audit and remaining risks.

Testing

  • go test -count=1 ./...
  • go test -count=1 -race ./...
  • go vet ./...
  • go build ./...
  • git diff --check

- Stage FTP/SFTP transfers before replacing targets
- Validate mapping boundaries and collisions across config, mapper, and host form
- Add regression tests and document the audit fixes
@nibra180
nibra180 merged commit 4b9f725 into main Jul 29, 2026
3 checks passed
@nibra180
nibra180 deleted the fix/critical-sync-audit branch July 29, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant