fix(diffview): reuse the existing connection for the first diff worker - #8
Merged
Merged
Conversation
forEachCompare opened a fresh connection for every FTP worker, leaving the already established one unused. On a server that allows only one session per user browsing worked, but every diff file then failed with a worker connect error. The first worker now always runs on the existing connection. Only additional FTP workers connect on their own and are best-effort: a worker that cannot connect exits and lowers parallelism instead of failing its jobs. That removes the connErr channel from compareFunc and simplifies both callers. SFTP keeps sharing its single pipelined connection across all workers. Tested against a real in-process FTP server: one allowing a single session (all files compare cleanly, extra workers still try) and one allowing several (the pool still grows beyond the first worker). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./internal/tui/diffview