added Caching Mouse Coordinates to reduce redundant calls#4228
Closed
Chewbakka-Wakka wants to merge 3 commits intoWarzone2100:masterfrom
Closed
added Caching Mouse Coordinates to reduce redundant calls#4228Chewbakka-Wakka wants to merge 3 commits intoWarzone2100:masterfrom
Chewbakka-Wakka wants to merge 3 commits intoWarzone2100:masterfrom
Conversation
Contributor
Author
|
mouseInBox may be another candidate |
Member
|
Fortunately, Also, in the future, please try to avoid unrelated changes - such as to whitespace or formatting - when opening a PR. It makes it harder to review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces redundant calls, by Caching of mouseX() and mouseY() at the start of processMouseClickInput
Why do?
mouseX() and mouseY() functions are called multiple times per frame, and each call recomputes the mouse coordinates.
Note on explicit assignment to help make intent clearer.
Some comments re-shuffled.
held off on changing mousePos -> Vector2i. Seen elsewhere though.