[CI] Add Infer Static Code Analysis

[avinal]

Changes

• Fixes Create a static code analysis report #519
• Uses GitHub Actions and https://github.com/facebook/infer
• The report can be accessed in the GiHub Actions logs

Test Runs

• https://github.com/avinal/WasmEdge/runs/3973355777?check_suite_focus=true#step:5:159

Signed-off-by: Avinal Kumar avinal.xlvii@gmail.com

[codecov]

Codecov Report

Merging #521 (1cc7662) into master (cf290a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files         115      115           
  Lines       15186    15186           
  Branches     3539     3539           
=======================================
  Hits        10710    10710           
  Misses       2480     2480           
  Partials     1996     1996           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf290a4...1cc7662. Read the comment docs.

[juntao]

Thanks! Does it cover the source files under the tools folder?

[avinal]

Thanks! Does it cover the source files under the tools folder?

No, I did not see into optional components. let me add it. Should I add tests too?

[juntao]

I added some changes. Can you trigger it to run again on your repo? Thanks!

[avinal]

No, I can't see any option to manually trigger. As far as I remember it must be merged before forks can use it.

[juntao]

Hmm, how did you create those github actions reports in your repo then? 😂

[avinal]

Well, when I was testing, I added a trigger on my pull request branch, later I amended the commits 🤭.

[juntao]

That is a neat trick. Can I ask you to do the same so that we can have a build with uploaded report.txt artifact? Thanks!

[avinal]

Yeah sure, I identified some mistakes too, I will fix them.

[avinal]

report.zip
Here is a report from the latest run: https://github.com/avinal/WasmEdge/runs/3982850452?check_suite_focus=true

[juntao]

Hmm, this report only has 4 issues. Run 6 identified 26?

https://github.com/avinal/WasmEdge/runs/3973556059?check_suite_focus=true#step:5:272

[avinal]

Ohh I see now. Seems like there is a conflict in results between different ways to analyze using CMake. https://fbinfer.com/docs/next/analyzing-apps-or-projects#cmake

I just wanted to see which method is faster, assuming both will produce the same result. Let me try that again.

[avinal]

Got 28 now 😕
report.txt

[juntao]

Thanks! :)

One more thing -- you might need to clean up the test commits to fix the DCO requirements.

[juntao]

I think this looks good.

[juntao]

Thank you @avinal for your contribution. I added all issues identified by fbinfer as hacktoberfest issues. :)

https://github.com/WasmEdge/WasmEdge/issues?q=is%3Aissue+is%3Aopen+label%3AImprovement

[avinal]

Thanks @juntao, I will try to pick some issues in the coming days. Just for the note, a redundant line slipped through our reviews. I have added a PR to fix that.