feat: confirm-and-override dialog for stale proposal conflicts - #397
Open
Scr4tch587 wants to merge 1 commit into
Open
feat: confirm-and-override dialog for stale proposal conflicts#397Scr4tch587 wants to merge 1 commit into
Scr4tch587 wants to merge 1 commit into
Conversation
ApiError now carries the parsed response body so callers can inspect structured fields beyond detail. the create-dataset form catches a 409 stale_branch conflict and offers to close the stale pr (if any), delete the branch, and resubmit -- a dataset_exists conflict still just shows the existing inline error with no override option.
|
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the stale-branch conflict info from the API into the create-dataset form.
What changed:
Testing: `bun run typecheck`, `bun run lint`, `bun run format:write`, and `bun run build` all pass. Smoke-tested the form in a scratch dev server (Chrome) — renders and opens with no console errors; the actual 409 trigger needs a live backend to exercise end-to-end, covered by the backend-layer tests in the earlier PRs in this stack.
Benefit: re-testing/re-proposing a dataset name whose earlier proposal PR was closed without deleting the branch no longer requires a human to manually clean up the branch via the GitHub API/UI — the form surfaces it and lets the user recover in place.