Skip to content

Swap login button color to green#816

Closed
lenisko wants to merge 5 commits into
WatWowMap:developfrom
lenisko:login_color
Closed

Swap login button color to green#816
lenisko wants to merge 5 commits into
WatWowMap:developfrom
lenisko:login_color

Conversation

@lenisko

@lenisko lenisko commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

I open the discussion!

...

Screenshots below

@TurtIeSocks

Copy link
Copy Markdown
Collaborator

Interesting choice.

@lenisko

lenisko commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author

Broken one ;)

@lenisko

lenisko commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author

Someone reused component named DiscordLogin to Join and few other places 😂

@lenisko

lenisko commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author

Added screenshot as an example. I need some IDE for JS...

Some smaller color changes might be needed, as white part is not visible enough.

@TurtIeSocks

TurtIeSocks commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator

Seems very bright. How does it look in light mode? Try using the color="success" prop to use the theme green.

@lenisko

lenisko commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author
Screenshot 2023-08-15 at 01 16 26 Screenshot 2023-08-15 at 01 16 23

@lenisko

lenisko commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

Got scolded by my personal UX... Apparently, should use PRIMARY and SECONDARY colors...

@TurtIeSocks

Copy link
Copy Markdown
Collaborator

So what are we thinking...

@roundaboutluke

Copy link
Copy Markdown

Discord’s blurple change recently to #5865F2. While I’m not a fan of the green either way it would be better to stick within the branding guidelines and use #57F287 for that.

https://discord.com/branding

@lenisko

lenisko commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

Well, it makes sense, but #57F287 is ultra bright 😓

@TurtIeSocks

Copy link
Copy Markdown
Collaborator

Agreed, that Discord green is brutal on the eyes.

@roundaboutluke

Copy link
Copy Markdown

God even on black it’s bad. They all are just tried them all. I’d say just update blurple and be done with it. Custom login page can be used for anything beyond really and I do agree some sort of default distinction is good for new mappers to get going with.

@TurtIeSocks

Copy link
Copy Markdown
Collaborator

Resolved in #826, apologies @lenisko. Forgot to take it out when I was playing with it while we were talking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants