feat: showcase form support#884
Merged
Merged
Conversation
Contributor
|
Not seeing correct form it seems. I'll debug later today/tonight. Thanks! |
Collaborator
Author
|
The db entry and what's being sent to the client aren't matching or it's being collected incorrectly from protos? |
Contributor
|
I was just dumb and failed to actually start the new version properly. It works! :) |
Contributor
|
2 different pokestops, showing correct forms now:
Thank you :) |
Contributor
|
Does this handle null for form_id ? At least not bomb? null would indicate that all forms are allowed, based on what I did in Golbat. |
Collaborator
Author
|
It defaults it to 0 in one spot, but for now it's inconsequential because there aren't any filtering options. I may make a slight adjustment knowing that null = all though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds backwards compatible support for UnownHash/Golbat#188