Update GeoURI to drop a pin when opened with Google Maps - #990
Merged
Conversation
frett
commented
Mar 25, 2024
| { | ||
| "name": "GeoURI", | ||
| "url": "geo:{x},{y}" | ||
| "url": "geo:{x},{y}?q={x},{y}" |
Contributor
Author
There was a problem hiding this comment.
@TurtIeSocks I'm assuming you can use the replacement variables multiple times in a pattern
Collaborator
There was a problem hiding this comment.
Not currently but if you change
to use
replaceAll instead of replace (or a regex) then it shouldn't be a problem.
Collaborator
|
Thanks for the PR but can you change the target to |
Contributor
Author
|
give me a second to rebase and remove the other changes that are from master :) |
Wikipedia lists an unofficial extension using the `q` parameter to have Google Maps show a pin from a GeoURI. See: https://en.wikipedia.org/wiki/Geo_URI_scheme#Unofficial_extensions I tested this on Android Google Maps and opening the link directly through the Tesla app. I also tested the url pattern: `geo:0,0?q={x},{y}`, but opted to go with the committed pattern to account for external maps that may not recognize the `q` parameter
TurtIeSocks
approved these changes
Mar 25, 2024
TurtIeSocks
left a comment
TurtIeSocks
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thank you for the contribution!
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wikipedia lists an unofficial extension using the
qparameter to have Google Maps show a pin from a GeoURI. See: https://en.wikipedia.org/wiki/Geo_URI_scheme#Unofficial_extensionsI tested this on Android Google Maps and opening the link directly through the Tesla app.
I also tested the url pattern:
geo:0,0?q={x},{y}, but opted to go with the committed pattern to account for external maps that may not recognize theqparameter