#108 Upgraded lxml dependency from 3.6.1 to 3.6.4. #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to upgrade further, but don't think it's prudent until we get unit tests and integration tests sorted in WattTime#130. Then we could probably bump the version up further. For now, I think upgrading the dependency from 3.6.1 to 3.6.4 is fairly safe (unit tests pass) and the version change bring in stabilization fixes only. See http://lxml.de/3.6/changes-3.6.4.html for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to upgrade further, but don't think it's prudent until we get
unit tests and integration tests sorted in #130. Then we could probably
bump the version up further.
For now, I think upgrading the dependency from 3.6.1 to 3.6.4 is fairly
safe (unit tests pass) and the version change bring in stabilization fixes
only. See http://lxml.de/3.6/changes-3.6.4.html for details.