Conversation
|
Our tests were failing due to two issues:
For now, this will fix failing tests and should be more robust to changes in the future. |
Note we are still allowing an unsupported python 3.8 so pytz could be necessary. I have added a task to upgrade this package to require python 3.10+ before we release it again. |
There was a problem hiding this comment.
The nature of the tests here is to test dates which do not change, across 3 years of available data. It would change the nature of these tests to derivce dates at execution time. I suggest we keep the explicit use of a year (formely 2022, 2023, and 2024) and bump the hardcoded date years to valid years, i.e. 2025 and 2026. I have only attempted this for the sdk file but the tcy requires it a well.
7a6f7e6 to
f9d9dd0
Compare
f9d9dd0 to
3d239ce
Compare
|
@jcofield tests are passing locally for me in my 3.11.15 venv. This matches the behavior of the github action which runs for each commit in this PR.
|
2a17932 to
6d7b881
Compare
6d7b881 to
6131ae9
Compare
|
After discussion, we went with a simpler solution of bumping years |
nsteins
left a comment
There was a problem hiding this comment.
LGTM. I think we should remove pytz from our code in the future, if we can, but that is a different PR

What
Fix failing tests
Why
To ensure that our tests pass so that we can run them every 30 minutes as a github action
How
Add pytz as a dependency annd replace hardcoded request start times