Conversation
sam-watttime
previously approved these changes
Apr 16, 2026
Contributor
sam-watttime
left a comment
sam-watttime
left a comment
There was a problem hiding this comment.
let's clean up the unrelated git diff, but the core change LGTM
This reverts commit 6f47e43.
nsteins
force-pushed
the
include-imputed-marker
branch
from
a4aaaa7 to
f00f0ec
Compare
Contributor
Author
|
Closed in favor of #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our /historical endpoint supports returning
imputed_data_usedmarkers, which are valuable when evaluating how often we use fallbacks in practice. I added this feature to support internal WattTime data report cards, which rely on and points at #62 , so this branch is based off that branch.However, I also merged in the changes from main (#67 ) so that tests would work, so there are some additional changes in this PR currently. Ideally, we would merge in #62 and then point this PR at main to isolate the changes around imputed_data