PR integrating engine into new trainers and finalizing the multi-gpu fix #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicitly move non-torch.nn losses.
…nhance data loader handling, and progress bar that includes within-epoch batch number update.
…e as backend with logging, training, and evaluation methods
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
wli51
changed the title
jenna-tomkinson
approved these changes
Nov 20, 2025
Member
jenna-tomkinson
left a comment
jenna-tomkinson
left a comment
There was a problem hiding this comment.
LGTM! I added some comments and questions to address prior to merging, but overall looks cool and very concise!
…ions and improved dataset handling
wli51
force-pushed
the
dev-fix-multi-gpu-update-trainer
branch
from
3666d08 to
8c395cf
Compare
… of results for clarity
Collaborator
Author
|
Thanks for reviewing @jenna-tomkinson! I have applied changes to address all of your suggestions. Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Following previous PRs (#17 , #18, #19) that implements the infrastructure to abstract away the model training complexity away from trainer and enforcing more robust device management, this PR finally integrates the parts from previous PRs into the trainer.
Adds
src/virtual_stain_flow/trainers/logging_trainer.py: simplified logging trainer utilizing new training infraexamples/training_with_logging_example.ipynb: new example to demo logging trainerRefactors (minor)
src/virtual_stain_flow/engine/loss_group.pyto better integrate with
AbstractTrainersrc/virtual_stain_flow/trainers/AbstractTrainer.py: to show a training progress barRemoves
All the obsolete trainer classes