Fix safe-heap regression with handling of existing imports#1237
Fix safe-heap regression with handling of existing imports#1237
Conversation
|
For some reason flake8 is now showing errors it didn't before (on stuff not changed by this PR). Very strange. I pushed what I think is a fix, but does anyone know why it flake8 would suddenly check more things? |
|
Looks like it upgraded from |
| apply_passes(smaller) | ||
| assert run() == normal | ||
| except: | ||
| except Exception, e: |
There was a problem hiding this comment.
Modern style is except Exception: or except Exception as e:
|
I don't know what's going on with this PR... now the windows machines are showing an error on unchanged code, as if they also just changed to new settings... Worse, this doesn't makes sense. It says |
|
Yeah, gcc on appveyor bot has upgraded from 6.3 to 7.2. Could be a gcc bug. I don't see anything in the tracker that looks similar, though :( |
67eea87 to
712e0ac
Compare
|
Anyhow, there's a better PR for the python stuff, #1239, and I'll look into the new gcc failure separately as well. Merging this PR which is unrelated to those two new failures, and which fixes existing breakage. |
That case wasn't tested. Added a test with the fix.