Conversation
Member
|
Alternatively, maybe it's ok to have it update to new versions, and we'll get further improvements enforced? The fixing is fairly simple each time. I could go either way on this. |
Member
Author
|
I agree although I think its preferable to be in control of when we choose to update rather than having travis start failing for an external reason. |
Member
|
Ok, lgtm. Before merging though please merge in latest master to here to see that things pass, as we just merged flake8 fixes (so there's some risk of collision, probably very small though). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1237, and WebAssembly/waterfall#260