Add BYN_DEBUG/BYN_TRACE macros similar to LLVM's debug system#2496
Merged
Add BYN_DEBUG/BYN_TRACE macros similar to LLVM's debug system#2496
Conversation
This allows for debug trace message to be split my channel. So you can pass `--debug` to simply debug everything, or `--debug-only=opt` to only debug wasm-opt. This change is the initial introduction but as a followup I hope to convert all tracing over to this new system so we can more easily control the debug output.
tlively
approved these changes
Dec 4, 2019
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
This looks great! I like the use of the BYN_* prefix, and I think we should change WASM_UNREACHABLE to be BYN_UNREACHABLE for consistency as a followup.
| // To use these macros you must define DEBUG_TYPE to a C string within your | ||
| // source code which then acts as the name of a channel which can be | ||
| // individually enabled via --debug=<chan>. Specifing --debug without any | ||
| // argument enabled all channels. |
Member
There was a problem hiding this comment.
Suggested change
| // argument enabled all channels. | |
| // argument enables all channels. |
Member
Author
|
Checkout the followup PR that simplifies a lot of the debug handling: #2497 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for debug trace message to be split my channel. So you
can pass
--debugto simply debug everything, or--debug-only=optto only debug wasm-opt.
This change is the initial introduction but as a followup I hope to
convert all tracing over to this new system so we can more easily
control the debug output.