Conversation
This means that debugging/tracing can now be enabled and controlled centrally without managing and passing state around the codebase.
sbc100
force-pushed
the
use_debug_macros
branch
from
ae272c1 to
5d57e5b
Compare
tlively
approved these changes
Dec 4, 2019
| std::cerr << "writeU32LEB: " << x.value << " (at " << before << ")" | ||
| << std::endl; | ||
| } | ||
| BYN_DEBUG(before = size(); std::cerr << "writeU32LEB: " << x.value |
Member
There was a problem hiding this comment.
It's a little strange that the debug statement has a side effect of assigning to before here. It looks like before is only used inside the BYN_DEBUG code, so I think removing it and just using size() would be a good simplification. The same goes for the other before variables in subsequent functions.
Member
Author
There was a problem hiding this comment.
I had a go, but the second debug block wants to use the old size before
sbc100
added a commit
that referenced
this pull request
Dec 4, 2019
This like was mistakenly removed as part of the BYN_TRACE conversion.
sbc100
added a commit
that referenced
this pull request
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that debugging/tracing can now be enabled and controlled
centrally without managing and passing state around the codebase.