Skip to content

[OptimizeInstructions] Canonicalize relational ops with near zero on rhs #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 26, 2021
Merged

[OptimizeInstructions] Canonicalize relational ops with near zero on rhs #4272

merged 11 commits into from
Oct 26, 2021

Conversation

@MaxGraey
Copy link
Contributor

@MaxGraey MaxGraey commented Oct 22, 2021 •
edited
Loading

Canonicalize:
(signed)x > -1 ==> x >= 0
(signed)x <= -1 ==> x < 0
(signed)x < 1 ==> x <= 0
(signed)x >= 1 ==> x > 0
(unsigned)x < 1 ==> x == 0
(unsigned)x >= 1 ==> x != 0

This should helps for #4265 and other pattern matchings

@MaxGraey MaxGraey changed the title [OptimizeInstructions] Canonicalize x > -1 and x <= -1 to relational op with zero instead -1 on rhs [OptimizeInstructions] Canonicalize relational ops with near zero on rhs Oct 23, 2021
@MaxGraey
Copy link
Contributor Author

MaxGraey commented Oct 24, 2021

Fuzzed ITERATION: 15477

@MaxGraey MaxGraey mentioned this pull request Oct 25, 2021
Open
kripken
kripken approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this makes sense to do, and looks like on the wasm2js outputs it is already of some benefit, even.

@MaxGraey @kripken
Update src/passes/OptimizeInstructions.cpp
c8d4276 
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
@kripken kripken enabled auto-merge (squash) October 26, 2021 23:01
@kripken kripken merged commit 2b24537 into WebAssembly:main Oct 26, 2021
@MaxGraey MaxGraey deleted the canon-some-relationals branch October 26, 2021 23:18
@MaxGraey MaxGraey mentioned this pull request Oct 27, 2021
Merged
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Oct 27, 2021
@sbc100
Rebaseline codesize test expectations. NFC
13c20fa 
We had one test (test_minimal_runtime_code_size_random_printf_wasm2js)
that was improved so much that it crossed the threshold and
was failing.

Looks like it was thanks to  WebAssembly/binaryen#4272!
@sbc100 sbc100 mentioned this pull request Oct 27, 2021
Merged
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Oct 28, 2021
@sbc100
Rebaseline codesize test expectations. NFC (#15375)
3745222 
We had one test (test_minimal_runtime_code_size_random_printf_wasm2js)
that was improved so much that it crossed the threshold and
was failing.

Looks like it was thanks to  WebAssembly/binaryen#4272!
tlively pushed a commit that referenced this pull request Aug 27, 2022
@MaxGraey
[OptimizeInstructions] Canonicalize relational ops near min/max values (
d5b6972 
#4282)

A continuation of #4272.

```
(signed)x  < s_min + 1   ==>   x == s_min
(signed)x >= s_min + 1   ==>   x != s_min
(signed)x  > s_max - 1   ==>   x == s_max
(signed)x <= s_max - 1   ==>   x != s_max

(unsigned)x <= u_max - 1   ==>   x != u_max
(unsigned)x  > u_max - 1   ==>   x == u_max
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @kripken