Skip to content

[OptimizeInstructions] Canonicalizations for relational ops near signed & unsigned min/max #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 27, 2022
Merged

[OptimizeInstructions] Canonicalizations for relational ops near signed & unsigned min/max #4282

merged 7 commits into from
Aug 27, 2022

Conversation

@MaxGraey
Copy link
Contributor

@MaxGraey MaxGraey commented Oct 27, 2021 •
edited
Loading

It's continue of #4272

(signed)x  < s_min + 1   ==>   x == s_min
(signed)x >= s_min + 1   ==>   x != s_min
(signed)x  > s_max - 1   ==>   x == s_max
(signed)x <= s_max - 1   ==>   x != s_max

(unsigned)x <= u_max - 1   ==>   x != u_max
(unsigned)x  > u_max - 1   ==>   x == u_max

@MaxGraey MaxGraey mentioned this pull request Oct 27, 2021
Open
@MaxGraey
Copy link
Contributor Author

MaxGraey commented Oct 27, 2021

Fuzzed ITERATION: 14043

@MaxGraey
Copy link
Contributor Author

MaxGraey commented Jan 27, 2022

@kripken @tlively Could you take a look to this please?

@MaxGraey
Copy link
Contributor Author

MaxGraey commented Aug 25, 2022

@tlively Could you take a little look at this old PR please?

tlively
tlively reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with that one comment.

@tlively tlively merged commit d5b6972 into WebAssembly:main Aug 27, 2022
@MaxGraey MaxGraey deleted the more-relational-cannon branch August 27, 2022 03:52
@MaxGraey
Copy link
Contributor Author

MaxGraey commented Aug 27, 2022

@tlively Thanks!

kripken
kripken reviewed Aug 29, 2022
View reviewed changes
test/lit/passes/optimize-instructions.wast
(local.get $y)
(i64.const 9223372036854775806)
))
;; (unsigned)x <= u_max - 1 ==> x == u_max
Copy link
Member

@kripken kripken Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text here is wrong, == should be != (but the optimizer output is right).

Same in the comment below, != should be ==.

Copy link
Contributor Author

@MaxGraey MaxGraey Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch. Do you want a separate PR which fix this comment or just append this minor fix with some other existing PR?

Copy link
Member

@kripken kripken Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate PR might be simplest. I am not up to date on the other PRs and am not sure when they will land. A separate PR can be landed immediately.

Copy link
Contributor Author

@MaxGraey MaxGraey Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4992

@MaxGraey MaxGraey mentioned this pull request Aug 30, 2022
Merged
kripken pushed a commit that referenced this pull request Aug 30, 2022
@MaxGraey
Fix test comments (#4992)
e50ef7f 
Followup to #4282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken left review comments

@tlively tlively tlively approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxGraey @kripken @tlively