[GC][EH] Fuzz exnref in GC structs#7288
Merged
kripken merged 13 commits intoWebAssembly:mainfrom Feb 13, 2025
Merged
Conversation
aheejin
approved these changes
Feb 12, 2025
Comment on lines
+164
to
+170
| std::vector<HeapType> options{HeapType::func, | ||
| HeapType::ext, | ||
| HeapType::any, | ||
| HeapType::eq, | ||
| HeapType::i31, | ||
| HeapType::struct_, | ||
| HeapType::array}; |
Member
There was a problem hiding this comment.
Given that we check for features.hasExceptionHandling() for exn, don't we also need to check for features.hasGC() or something for these?
Member
Author
There was a problem hiding this comment.
I think this entire file is for fuzzing of heap types, so GC is assumed everywhere. This is a separate file from the main fuzzer.
Co-authored-by: Heejin Ahn <aheejin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the work here is avoiding shared and non-nullable exnref in
various places, as we cannot support those in the fuzzer (I don't see
a way to generate shared exnrefs, and non-nullable ones can be
created but not in global places, as the way to create them needs a
block and a try).
Some example output: