[EH] Fuzz exnref in tables#7289
Merged
kripken merged 16 commits intoWebAssembly:mainfrom Feb 14, 2025
Merged
Conversation
Member
Author
|
This depends on #7290 but otherwise looks stable under fuzzing. |
aheejin
reviewed
Feb 12, 2025
| index = make(table->addressType); | ||
| } else { | ||
| index = builder.makeConst( | ||
| Literal::makeFromInt32(table->initial, table->addressType)); |
Member
There was a problem hiding this comment.
Do we only get from the initial index? (The same for table.set)
Member
Author
There was a problem hiding this comment.
Good catch! This should be upTo(table->initial). Fixed.
Member
There was a problem hiding this comment.
So we don't support table.grow in the fuzzer and the size is the same as initial?
Member
Author
There was a problem hiding this comment.
We should add table.grow support, but yeah, for now the size will be fixed.
| if (type.getHeapType() == HeapType::exn) { | ||
| return makeTableGet(exnrefTableName); | ||
| } else { | ||
| return makeTableGet(funcrefTableName); |
Member
There was a problem hiding this comment.
Is it always HeapType::func here? Can we assert? (The same for makeTableSet)
Member
Author
There was a problem hiding this comment.
Good idea, I added asserts.
aheejin
approved these changes
Feb 12, 2025
Member
Author
|
CI errors here might be fixed by #7288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
table.getOpening as draft as I see some fuzzer errors that need to be fixed.