[EH] Prune exnref-returning/receiving exports#7290
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Feb 12, 2025
Merged
Conversation
aheejin
reviewed
Feb 12, 2025
| ;; CHECK-NEXT: (ref.null noexn) | ||
| ;; CHECK-NEXT: ) | ||
| (func $export-exn (export "export-exn") (result exnref) | ||
| ;; This will be pruned. |
Member
There was a problem hiding this comment.
Where do we see that it is pruned? (The CHECK lines are the same, so..)
Member
Author
There was a problem hiding this comment.
The export is pruned, specifically. It is exported in the input but not in the output.
aheejin
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like v128, JS VMs will trap on an exnref on the boundary between JS and wasm,
so the fuzzer must prune such exports (we run that pruning when we intend
to compare d8 to the binaryen interpreter; after the pruning, all exports should
behave the same between those VMs).