Require matching finality - #112
Merged
Merged
Conversation
Rule out the nonsensical configurations in which finalities of descriptor and described types are mismatched. In these configurations, it would not be possible for the non-final type to have subtypes, so we might as well require it to be final. Closes #61.
Member
Author
|
@rossberg, do the CI failures setting up OCaml look familiar to you? Is that something that a merge from the upstream spec would fix? |
rossberg
approved these changes
Sep 1, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
Looks good.
Re CI failures: not sure. But dependency handling has been cleaned up upstream (plus it moved to OCaml 5). So if rerunning the job does not fix it, perhaps consider syncing with upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule out the nonsensical configurations in which finalities of descriptor and described types are mismatched. In these configurations, it would not be possible for the non-final type to have subtypes, so we might as well require it to be final.
Closes #61.