Skip to content

Conversation

@lukewagner
Copy link
Member

This patch moves the linear memory operations a bit closer to the design doc. It doesn't attempt to fix the type naming situation (#26) but it does:

  • remove the near/far distinction since >4GiB heaps are future feature. The SExpr opcode names are future-compatible under the assumption that we bias toward near ops ("" means near, "far" means far);
  • rename get* to load and set* to store.

@MikeHolman
Copy link
Member

Can you update in the readme as well? Otherwise lgtm

@lukewagner lukewagner mentioned this pull request Aug 27, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here... ASTSemantics also names load_global and store_global.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bet

@rossberg
Copy link
Member

Other than the README, lgtm.

lukewagner added a commit that referenced this pull request Aug 27, 2015
Remove near|far split and rename (Get|Set)Memory
@lukewagner lukewagner merged commit a4ce01f into master Aug 27, 2015
@lukewagner
Copy link
Member Author

Merging based on lgtm

@lukewagner
Copy link
Member Author

Oh oops, I didn't see I only updated half the README.md, will update the "external syntax" now.

@lukewagner lukewagner deleted the rm-far branch August 27, 2015 14:31
littledan pushed a commit to littledan/spec that referenced this pull request Mar 4, 2018
alexcrichton pushed a commit to alexcrichton/spec that referenced this pull request Nov 19, 2019
dhil added a commit to dhil/webassembly-spec that referenced this pull request Apr 11, 2023
…trol-lwt.wast still needs to be refactored to use cont.bind+new syntax) (WebAssembly#30)
backes pushed a commit to backes/spec that referenced this pull request Jul 12, 2023
dhil added a commit to dhil/webassembly-spec that referenced this pull request Apr 12, 2024
CharlieTap pushed a commit to CharlieTap/spec that referenced this pull request Sep 25, 2025
stevenfontanella pushed a commit to stevenfontanella/spec that referenced this pull request Nov 12, 2025
Also ignore additional directories when attempting to merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants