-
Notifications
You must be signed in to change notification settings - Fork 505
Remove near|far split and rename (Get|Set)Memory #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you update in the readme as well? Otherwise lgtm |
ml-proto/src/ast.ml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're here... ASTSemantics also names load_global and store_global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You bet
|
Other than the README, lgtm. |
Remove near|far split and rename (Get|Set)Memory
|
Merging based on lgtm |
|
Oh oops, I didn't see I only updated half the README.md, will update the "external syntax" now. |
It's easier to read this way.
Clarify subsections
…trol-lwt.wast still needs to be refactored to use cont.bind+new syntax) (WebAssembly#30)
Fix typo in Overview.md
Also ignore additional directories when attempting to merge.
This patch moves the linear memory operations a bit closer to the design doc. It doesn't attempt to fix the type naming situation (#26) but it does:
get*toloadandset*tostore.