Editorial: try to clarify the JS API#212
Merged
conrad-watt merged 1 commit intoWebAssembly:upstream-rebuildfrom Sep 28, 2023
Merged
Editorial: try to clarify the JS API#212conrad-watt merged 1 commit intoWebAssembly:upstream-rebuildfrom
conrad-watt merged 1 commit intoWebAssembly:upstream-rebuildfrom
Conversation
conrad-watt
reviewed
Sep 12, 2023
| 1. Let |newBuffer| be the result of [=create a fixed length memory buffer|creating a fixed length memory buffer=] from |memaddr|. | ||
| 1. Set |memory|.\[[BufferObject]] to |newBuffer|. | ||
| 1. Otherwise, | ||
| 1. Issue: Is this safe for a SharedArrayBuffer? |
Collaborator
There was a problem hiding this comment.
Ah, this is a good point. It might not be right to operationally get the "length of |block|" in the SAB case this way.
Collaborator
There was a problem hiding this comment.
I'm currently super jetlagged from Wasmcon but I'll try to think more clearly about the right way to do this SAB case.
conrad-watt
approved these changes
Sep 28, 2023
Collaborator
conrad-watt
left a comment
conrad-watt
left a comment
There was a problem hiding this comment.
lgtm, I'll fix the SAB size check issue I commented on above in a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.