Update wasi-headers to use reorganized witx ast#139
Merged
Conversation
sunfishcode
reviewed
Nov 22, 2019
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
The changes look good. The things left to do here are rebasing this on master now that the changes it depends on are merged, and including the generated api.h in the commit.
pchickey
force-pushed
the
pch/reorg_witx_ast
branch
from
70b4217 to
720467f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #136 .
Updates
wasi-headersto thewitxAST updates.Should wait to merge this until WebAssembly/WASI#154 is merged, and point at the release commit in master.