Update to the latest witx files, including wasi_snapshot_preview1.#21
Closed
sunfishcode wants to merge 3 commits intomasterfrom
Closed
Update to the latest witx files, including wasi_snapshot_preview1.#21sunfishcode wants to merge 3 commits intomasterfrom
sunfishcode wants to merge 3 commits intomasterfrom
Conversation
Most editors these days can deal with eof=lf files, even on Windows, and this avoids trouble with headers and other generated files differing in line endings.
This appears needed now that witx is a local dependency.
Closed
Collaborator
|
Awesome, I'll add the equivalent of WebAssembly/wasi-libc#139 as a separate PR shortly |
alexcrichton
approved these changes
Nov 22, 2019
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
FWIW I'm working through #20 and am close to finishing as well, but if you'd like to publish this in the interim that also seems fine by me!
Member
|
Ok I merged in #22 which I think should cover this as well, so closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to the latest witx files in the WASI repo. The two most noticeable changes here are:
@pchickey This doesn't include WebAssembly/wasi-libc#139; it just updates to the witx which includes the new ABI, as well as the new names, similar to what I did in wasi-libc.