-
Notifications
You must be signed in to change notification settings - Fork 189
Add 0xb demo bits #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
demo/AngryBots/index.html
Outdated
| }; | ||
|
|
||
| var version = ""; | ||
| if (Wasm && Wasm.experimentalVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. feel free to ignore, but i would be happier with {} here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure; the style in this file is all over
|
I haven't tried the demo bits yet but we are basically there functionally. On Fri, Apr 22, 2016 at 6:30 PM, Luke Wagner notifications@github.com
|
|
Have you had a look at the burndown list recently? On Fri, Apr 22, 2016 at 6:47 PM, Ben L. Titzer titzer@google.com wrote:
|
|
@titzer Yes, it looks like the only diff from what is "titzer:CL" is the new |
|
Looks like we never landed a design PR for arities in call, return, and break? |
|
We need to rebase WebAssembly/design#595 onto binary_0xb and land that. |
|
Alright, assuming @rossberg-chromium can get that rebased, here are the updated bits with arities (and, to be clear, the |
|
How's it looking? |
|
@titzer It looks like we still need to land the |
|
LGTM. I've verified that Chrome is able to run these demo bits with this patch ( -B On Thu, Apr 28, 2016 at 6:36 AM, Seth Thompson notifications@github.com
|
|
I also verified the backup path works (i.e. falling back to 0xa) in Chrome. On Thu, Apr 28, 2016 at 2:32 PM, Ben L. Titzer titzer@google.com wrote:
|
|
Commence landing! |
This PR adds a (currently candidate) .wasm binary that matches the 0xb branch binary encoding in design. The only thing missing (which I'll upload tomorrow assuming design/#664 is merged) is the
br_tablevalue. I confirmed locally that it runs in the three configurations: no wasm (which just has the message), FF nightly (0xa), FF with patches (0xb).Happy to get any feedback and update the PR with new binary bits if any issues are found. I'll of course wait to confirm this decodes in at least one other engine before merging. (cc @binji @kripken @sunfishcode )