Skip to content

Conversation

@lukewagner
Copy link
Member

This PR adds a (currently candidate) .wasm binary that matches the 0xb branch binary encoding in design. The only thing missing (which I'll upload tomorrow assuming design/#664 is merged) is the br_table value. I confirmed locally that it runs in the three configurations: no wasm (which just has the message), FF nightly (0xa), FF with patches (0xb).

Happy to get any feedback and update the PR with new binary bits if any issues are found. I'll of course wait to confirm this decodes in at least one other engine before merging. (cc @binji @kripken @sunfishcode )

};

var version = "";
if (Wasm && Wasm.experimentalVersion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. feel free to ignore, but i would be happier with {} here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure; the style in this file is all over

@lukewagner
Copy link
Member Author

Now with br_table values. @kripken says SM bits run in Binaryen's 0xb interpreter. @binji / @titzer: lgty?

@titzer
Copy link

titzer commented Apr 22, 2016

I haven't tried the demo bits yet but we are basically there functionally.
I'll take a look at the bits tomorrow.

On Fri, Apr 22, 2016 at 6:30 PM, Luke Wagner notifications@github.com
wrote:

Now with br_table values. @kripken https://github.com/kripken says SM
bits run in Binaryen's 0xb interpreter. @binji https://github.com/binji
/ @titzer https://github.com/titzer: lgty?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/WebAssembly/webassembly.github.io/pull/5#issuecomment-213499963

@titzer
Copy link

titzer commented Apr 22, 2016

Have you had a look at the burndown list recently?

On Fri, Apr 22, 2016 at 6:47 PM, Ben L. Titzer titzer@google.com wrote:

I haven't tried the demo bits yet but we are basically there functionally.
I'll take a look at the bits tomorrow.

On Fri, Apr 22, 2016 at 6:30 PM, Luke Wagner notifications@github.com
wrote:

Now with br_table values. @kripken https://github.com/kripken says SM
bits run in Binaryen's 0xb interpreter. @binji https://github.com/binji
/ @titzer https://github.com/titzer: lgty?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/WebAssembly/webassembly.github.io/pull/5#issuecomment-213499963

@lukewagner
Copy link
Member Author

@titzer Yes, it looks like the only diff from what is "titzer:CL" is the new form field in the types section. Once you add that, I expect V8 should decode these bits.

@titzer
Copy link

titzer commented Apr 25, 2016

Looks like we never landed a design PR for arities in call, return, and break?

@titzer
Copy link

titzer commented Apr 25, 2016

We need to rebase WebAssembly/design#595 onto binary_0xb and land that.

@lukewagner
Copy link
Member Author

Alright, assuming @rossberg-chromium can get that rebased, here are the updated bits with arities (and, to be clear, the nop values removed from branches/return when arity=0).

@lukewagner
Copy link
Member Author

How's it looking?

@s3ththompson
Copy link
Member

@titzer It looks like we still need to land the experimentalVersion property?

@titzer
Copy link

titzer commented Apr 28, 2016

LGTM.

I've verified that Chrome is able to run these demo bits with this patch (
https://codereview.chromium.org/1896863003/).

-B

On Thu, Apr 28, 2016 at 6:36 AM, Seth Thompson notifications@github.com
wrote:

@titzer https://github.com/titzer It looks like we still need to land
the experimentalVersion property?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/WebAssembly/webassembly.github.io/pull/5#issuecomment-215308028

@titzer
Copy link

titzer commented Apr 28, 2016

I also verified the backup path works (i.e. falling back to 0xa) in Chrome.

On Thu, Apr 28, 2016 at 2:32 PM, Ben L. Titzer titzer@google.com wrote:

LGTM.

I've verified that Chrome is able to run these demo bits with this patch (
https://codereview.chromium.org/1896863003/).

-B

On Thu, Apr 28, 2016 at 6:36 AM, Seth Thompson notifications@github.com
wrote:

@titzer https://github.com/titzer It looks like we still need to land
the experimentalVersion property?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/WebAssembly/webassembly.github.io/pull/5#issuecomment-215308028

@lukewagner lukewagner merged commit e84ccaa into master Apr 28, 2016
@lukewagner lukewagner deleted the binary_0xb branch April 28, 2016 15:01
@lukewagner
Copy link
Member Author

Commence landing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants